chore(api): new output api #6677 #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Oct 1, 2017
src/lib/sidenav/drawer.ts
Outdated
| @Output('opened') | ||
| get _openedStream(): Observable<void> { | ||
| return RxChain.from(this.openedChange) | ||
| .call(filter, o => o) |
There was a problem hiding this comment.
nit: indent continuation lines 4 spaces
| (open)="open()" | ||
| (close)="close()"> | ||
| (opened)="open()" | ||
| (closed)="close()"> |
There was a problem hiding this comment.
can we add a test for the [(opened)] syntax as well
mmalerba
approved these changes
Oct 1, 2017
|
@amcdnl Rebase? |
kara
added
pr: needs rebase
and removed
action: merge
|
@kara - done :) |
|
One more time? :-) |
|
@kara - done :L |
mmalerba
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given all the back and forth on #7161, I decided to open a new clean PR with the changes. This PR does the following:
openedevent, deprecatingopenclosedevent, deprecatingcloseopenChange<boolean>