Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): alt + arrow key not opening in single-selection mode #8910

Merged
merged 1 commit into from
Dec 13, 2017
Merged

fix(select): alt + arrow key not opening in single-selection mode #8910

merged 1 commit into from
Dec 13, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 9, 2017

Fixes not being able to open a closed mat-select in single selection mode using the alt + up/down arrow combo. It seems like this was introduced when we added the ability go through the values using arrow keys on a closed select.

@crisbeto
fix(select): alt + arrow key not opening in single-selection mode
22c09c6 
Fixes not being able to open a closed `mat-select` in single selection mode using the alt + up/down arrow combo. It seems like this was introduced when we added the ability go through the values using arrow keys on a closed select.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Dec 9, 2017
@crisbeto crisbeto requested a review from kara as a code owner December 9, 2017 18:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 9, 2017
jelbourn
jelbourn approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 13, 2017
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Dec 13, 2017
@andrewseguin andrewseguin merged commit a4c042b into angular:master Dec 13, 2017
andrewseguin pushed a commit that referenced this pull request Dec 19, 2017
@crisbeto @andrewseguin
fix(select): alt + arrow key not opening in single-selection mode (#8910
85f83f9 
)

Fixes not being able to open a closed `mat-select` in single selection mode using the alt + up/down arrow combo. It seems like this was introduced when we added the ability go through the values using arrow keys on a closed select.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin