fix(select): handle async changes to the option label #9159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 12, 2018
src/lib/core/option/option.ts
Outdated
| private _selected = false; | ||
| private _active = false; | ||
| private _disabled = false; | ||
| private _id = `mat-option-${_uniqueIdCounter++}`; | ||
| private _oldViewValue = ''; |
src/lib/select/select.ts
Outdated
| } | ||
| }); | ||
|
|
||
| merge(...this.options.map(option => option._stateChanges)) |
There was a problem hiding this comment.
Add a comment here that explains what this is for?
crisbeto
force-pushed
the
7923/select-view-value-change
branch
from
8e9cc0e to
d35278b
Compare
|
Addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto passes presubmit, just needs rebase |
Currently `mat-select` doesn't react to changes in the label of its options, which is problematic, because the option label might be populated at a later point by a pipe or it might have changed while the select is closed. These changes add a `Subject` to the `MatOption` that will emit whenever the label changes and allows the select to react accordingly. Fixes angular#7923.
crisbeto
force-pushed
the
7923/select-view-value-change
branch
from
d35278b to
c46cd33
Compare
|
Rebased. |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
Currently `mat-select` doesn't react to changes in the label of its options, which is problematic, because the option label might be populated at a later point by a pipe or it might have changed while the select is closed. These changes add a `Subject` to the `MatOption` that will emit whenever the label changes and allows the select to react accordingly. Fixes angular#7923.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
mat-selectdoesn't react to changes in the label of its options, which is problematic, because the option label might be populated at a later point by a pipe or it might have changed while the select is closed. These changes add aSubjectto theMatOptionthat will emit whenever the label changes and allows the select to react accordingly.Fixes #7923.