fix(select): close panel on alt + arrow key presses #9250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crisbeto
commented
Jan 5, 2018
crisbeto
commented
- Closes the select panel when pressing alt + down/up arrow, based on the native select.
- Does some minor cleanup around the select tests.
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 11, 2018
jelbourn
reviewed
Jan 11, 2018
src/lib/select/select.ts
Outdated
| } else if ((keyCode === ENTER || keyCode === SPACE) && this._keyManager.activeItem) { | ||
| keyCode === HOME ? manager.setFirstItemActive() : manager.setLastItemActive(); | ||
| } else if (isArrowKey && event.altKey) { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
The comment was:
Add a comment here like
// Close the select on ALT + arrow key to match the native <select>
* Closes the select panel when pressing alt + down/up arrow, based on the native select. * Does some minor cleanup around the select tests.
crisbeto
force-pushed
the
select-alt-close
branch
from
a06d169 to
144f294
Compare
crisbeto
added
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
* Closes the select panel when pressing alt + down/up arrow, based on the native select. * Does some minor cleanup around the select tests.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.