Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expansion-panel): support two-way binding for the expanded property #9327

Merged
merged 1 commit into from
Jan 23, 2018
Merged

feat(expansion-panel): support two-way binding for the expanded property #9327

merged 1 commit into from
Jan 23, 2018

Conversation

crisbeto
Copy link
Member

  • Supports two-way binding to the expanded property on the expansion panel.
  • Fixes som wrong indentation in the tests.

Fixes #9311.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 10, 2018
@crisbeto crisbeto force-pushed the 9311/expansion-panel-expanded-two-way branch from 2f19e14 to d6e5533 Compare January 10, 2018 21:14
@crisbeto crisbeto removed the request for review from mmalerba January 10, 2018 21:14
noemi-salaun
noemi-salaun suggested changes Jan 10, 2018
View reviewed changes
Copy link

@noemi-salaun noemi-salaun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to add expandedChange in the MatExpansionPanel outputs ?

https://github.com/crisbeto/material2/blob/303e004527a74cb9da4bb894828c251741f63fbd/src/lib/expansion/expansion-panel.ts#L78

@crisbeto crisbeto force-pushed the 9311/expansion-panel-expanded-two-way branch from d6e5533 to fdf46b4 Compare January 10, 2018 22:49
jelbourn
jelbourn approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 10, 2018
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Jan 11, 2018
@crisbeto
feat(expansion-panel): support two-way binding for the expanded property
6ffbbd4 
* Supports two-way binding to the `expanded` property on the expansion panel.
* Fixes som wrong indentation in the tests.

Fixes angular#9311.
@crisbeto crisbeto force-pushed the 9311/expansion-panel-expanded-two-way branch from fdf46b4 to 6ffbbd4 Compare January 22, 2018 20:42
@jelbourn jelbourn merged commit a72085b into angular:master Jan 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noemi-salaun noemi-salaun noemi-salaun requested changes

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(expansion-panel): allow two-way binding on 'expanded' property
5 participants
@crisbeto @jelbourn @noemi-salaun @googlebot @josephperrott