fix(paginator): change class name of increment and decrement icons #9597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lharries
force-pushed
the
paginator-class-fix
branch
from
782ac8d to
924df08
Compare
lharries
force-pushed
the
paginator-class-fix
branch
from
22846de to
0d12179
Compare
andrewseguin
approved these changes
Jan 25, 2018
andrewseguin
added
pr: lgtm
action: merge
|
@lharries Please rebase. |
|
@tinayuangao this has been fixed by #9603 which has now been merged so I'm not sure this PR is needed too? |
|
@lharries Just need to rebase to master and resolve the conflicts. |
lharries
force-pushed
the
paginator-class-fix
branch
3 times, most recently
from
992ab4c to
73170ba
Compare
|
@tinayuangao it won't let me rebase as there are no changes to be made, as they have already been merged in #9603 |
Fix such that the previous page navigation button contains an icon with class decrement, and the next page navigation button contains an icon with class increment. Previously they were incorrectly swapped. Noticed during fix for angular#9278
lharries
force-pushed
the
paginator-class-fix
branch
from
354dd01 to
8194d0e
Compare
|
I have managed to rebase, however as you can see there are no changes |
|
No worries, this can be closed since the changes were in the other PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix such that the previous page navigation button contains an icon with class decrement,
and the next page navigation button contains an icon with class increment. Previously
they were incorrectly swapped.
Noticed during fix for #9278