fix(menu): not picking up indirect descendant items #9971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the menu directive not picking up menu items that aren't direct descendants of the panel. Fixes angular#9969.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
tinayuangao
pushed a commit
that referenced
this pull request
Feb 20, 2018
Fixes the menu directive not picking up menu items that aren't direct descendants of the panel. Fixes #9969.
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
Fixes the menu directive not picking up menu items that aren't direct descendants of the panel. Fixes #9969.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 22, 2018
Reverts the changes from angular#9971, because they break the case where a mat-menu is placed inside another mat-menu, causing the keyboard controls to be thrown off and nested menus not to work. Having a solution that supports both cases will require moving some more code around. Fixes angular#10083.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 22, 2018
Reverts the changes from angular#9971, because they break the case where a mat-menu is placed inside another mat-menu, causing the keyboard controls to be thrown off and nested menus not to work. Having a solution that supports both cases will require moving some more code around. Fixes angular#10081.
Merged
josephperrott
pushed a commit
that referenced
this pull request
Feb 22, 2018
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 26, 2018
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Feb 27, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the menu directive not picking up menu items that aren't direct descendants of the panel.
Fixes #9969.