fix(badge): move styles into the theme mixin #9999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The badge styles were defined _outside_ the mixin, meaning they were being included any time the file was imported.
googlebot
added
the
cla: yes
|
@crisbeto could a stylelint check capture this (concrete styles in a partial)? I've been seeing people make this mistake recently in Google, as well. |
crisbeto
approved these changes
Feb 18, 2018
crisbeto
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 18, 2018
Adds a stylelint rule that will ensure that all of the CSS rules inside theme files are placed inside a mixin. This avoids style duplication whenever the file is imported. Relates to angular#9999.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 19, 2018
Adds a stylelint rule that will ensure that all of the CSS rules inside theme files are placed inside a mixin. This avoids style duplication whenever the file is imported. Relates to angular#9999.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 19, 2018
Adds a stylelint rule that will ensure that all of the CSS rules inside theme files are placed inside a mixin. This avoids style duplication whenever the file is imported. Relates to angular#9999.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 20, 2018
Adds a stylelint rule that will ensure that all of the CSS rules inside theme files are placed inside a mixin. This avoids style duplication whenever the file is imported. Relates to angular#9999.
tinayuangao
pushed a commit
that referenced
this pull request
Feb 20, 2018
The badge styles were defined _outside_ the mixin, meaning they were being included any time the file was imported.
andrewseguin
added
the
target: minor
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 26, 2018
angular#10003) Adds a stylelint rule that will ensure that all of the CSS rules inside theme files are placed inside a mixin. This avoids style duplication whenever the file is imported. Relates to angular#9999.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Feb 27, 2018
angular#10003) Adds a stylelint rule that will ensure that all of the CSS rules inside theme files are placed inside a mixin. This avoids style duplication whenever the file is imported. Relates to angular#9999.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The badge styles were defined outside the mixin, meaning they were being included any time the file was imported.