Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

build: fix error with NodeJS on Linux/Chrome OS #11540

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Dec 13, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Running gulp on Chrome OS / Linux causes ReferenceError: internalBinding is not defined.

Issue Number:
Relates to isaacs/natives#14

What is the new behavior?

Running gulp on Chrome OS / Linux is successful.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar added this to the 1.1.11 milestone Dec 13, 2018
@Splaktar Splaktar self-assigned this Dec 13, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 13, 2018
@Splaktar Splaktar added type: build P2: required Issues that must be fixed. pr: merge safe pr: merge ready This PR is ready for a caretaker to review labels Dec 13, 2018
@Splaktar Splaktar assigned vivian-hu-zz and unassigned Splaktar Dec 13, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivian-hu-zz vivian-hu-zz merged commit 1512aa1 into master Dec 14, 2018
@Splaktar Splaktar deleted the fixNode10OnLinux branch December 14, 2018 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants