Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll smooth issue in dialog on close #10033

Closed
amaneer94 opened this issue Feb 20, 2018 · 2 comments · Fixed by #10139
Closed

Scroll smooth issue in dialog on close #10033

amaneer94 opened this issue Feb 20, 2018 · 2 comments · Fixed by #10139
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@amaneer94
Copy link

Bug, feature request, or proposal:

scroll is not fluent when dialog is closed.

What is the expected behavior?

on closing dialog, application scroll should be smooth

What is the current behavior?

when dialog is closed, scroll is rough

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Chrome/Chromium are affected but working good in opera
"@angular/core": "^5.2.0",
"@angular/material": "^5.2.1",
"typescript": "~2.5.3"

Is there anything else we should know?

<div class="cdk-overlay-container"></div> introduces when dialog is opened with
.cdk-overlay-container { position: fixed; z-index: 1000; }
after dialog is closed, I tried to remove both properties, scroll seemed smooth.

@crisbeto crisbeto self-assigned this Feb 20, 2018
@crisbeto
Copy link
Member

Spent some time looking into it, some things to keep in mind:

  • We need to rework the ConnectedPositionStrategy tests to go through the Overlay service.
  • We need to rework a bit in the menu and select components so they detach after their animation is finished, otherwise it'll be cut off.

@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Feb 20, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 25, 2018
Hides the `.cdk-overlay-container` if it doesn't have any attached overlays. This prevents the browser from rendering it as a transparent overlay.

Fixes angular#6882.
Fixes angular#10033.
tinayuangao pushed a commit that referenced this issue Feb 28, 2018
…ays (#10139)

Hides the `.cdk-overlay-container` if it doesn't have any attached overlays. This prevents the browser from rendering it as a transparent overlay.

Fixes #6882.
Fixes #10033.
tinayuangao pushed a commit that referenced this issue Mar 5, 2018
…ays (#10139)

Hides the `.cdk-overlay-container` if it doesn't have any attached overlays. This prevents the browser from rendering it as a transparent overlay.

Fixes #6882.
Fixes #10033.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants