Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tab-nav-bar): ripples still showing up when globally disabled #11865

Merged
merged 1 commit into from
Jun 29, 2018
Merged

fix(tab-nav-bar): ripples still showing up when globally disabled #11865

merged 1 commit into from
Jun 29, 2018

Conversation

devversion
Copy link
Member

  • If someone disables the ripples globally using the MAT_RIPPLE_GLOBAL_OPTIONS, the <mat-tab-nav-bar> still shows ripples. Ripples should be disabled for that custom RippleTarget as well.
  • By cloning and reinstalling the whole project, I ran into a runtime exception when running Gulp

Fixes #11847

@devversion devversion added the target: patch This PR is targeted for the next patch release label Jun 20, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 20, 2018
@devversion
fix(tab-nav-bar): ripples still showing up when globally disabled
c30ea86 
* If someone disables the ripples globally using the `MAT_RIPPLE_GLOBAL_OPTIONS`, the `<mat-tab-nav-bar>` still shows ripples. Ripples should be disabled for that custom `RippleTarget` as well.
* By cloning and reinstalling the whole project, I ran into a runtime exception when running Gulp

Fixes angular#11847
@devversion devversion force-pushed the fix/tab-nav-bar-ripple-global-disabled branch from 7e5f499 to c30ea86 Compare June 27, 2018 17:09
josephperrott
josephperrott approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 27, 2018
@josephperrott josephperrott merged commit fc1d1a4 into angular:master Jun 29, 2018
josephperrott pushed a commit that referenced this pull request Jun 29, 2018
@devversion @josephperrott
fix(tab-nav-bar): ripples still showing up when globally disabled (#1…
4f3cbfe 
…1865)
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@devversion @victoriaaa234
fix(tab-nav-bar): ripples still showing up when globally disabled (#1…
1dd2aa9 
…1865)
@justinappler justinappler mentioned this pull request May 23, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling ripple globally doesn't work globally
4 participants
@devversion @josephperrott @jelbourn @googlebot