Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): ripples still showing up when globally disabled #11918

Merged
merged 1 commit into from
Jun 26, 2018
Merged

fix(chips): ripples still showing up when globally disabled #11918

merged 1 commit into from
Jun 26, 2018

Conversation

devversion
Copy link
Member

  • If someone disables the ripples globally using the MAT_RIPPLE_GLOBAL_OPTIONS, chips will still shows ripples. Ripples should be disabled for that custom RippleTarget as well.

References #11847

@devversion
fix(chips): ripples still showing up when globally disabled
2bd3e3c 
* If someone disables the ripples globally using the `MAT_RIPPLE_GLOBAL_OPTIONS`, chips will still shows ripples. Ripples should be disabled for that custom `RippleTarget` as well.

References angular#11847
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jun 25, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 25, 2018
josephperrott
josephperrott approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 25, 2018
@josephperrott josephperrott merged commit 69a7f7c into angular:master Jun 26, 2018
josephperrott pushed a commit that referenced this pull request Jun 26, 2018
@devversion @josephperrott
fix(chips): ripples still showing up when globally disabled (#11918)
8d6a9ae
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@devversion @victoriaaa234
fix(chips): ripples still showing up when globally disabled (#11918)
3d1ee03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @josephperrott @jelbourn @googlebot @tinayuangao