perf(table): leaking reference through mostRecentCellOutlet

[crisbeto]

Fixes the table leaking out a reference to a cell outlet via the CdkCellOutlet.mostRecentCellOutlet after all tables have been destroyed.

Fixes #12259.

[jelbourn]

LGTM

[JamieMcI]

6.4.2 is generating this error when navigating from the page that I believe might be from this update.
Error: Uncaught (in promise): TypeError: o.ngOnDestroy is not a function

My Table setup (no issues in 6.4.1)
` <table mat-table #costs [dataSource]="dataSourceExp" class="mat-elevation-z8">

    <ng-container matColumnDef="type">
        <th mat-header-cell *matHeaderCellDef> Type </th>
        <td mat-cell *matCellDef="let expRow"> {{expRow.type}} </td>
    </ng-container>

    <ng-container matColumnDef="result">
        <th mat-header-cell *matHeaderCellDef class="table-number"> Result </th>
        <td mat-cell *matCellDef="let expRow" class="table-number"> {{expRow.result | number}} </td>
    </ng-container>

    <ng-container matColumnDef="calculated">
        <th mat-header-cell *matHeaderCellDef class="table-number"> Calculated </th>
        <td mat-cell *matCellDef="let expRow" class="table-number"> {{expRow.calculated | number}} </td>
    </ng-container>

    <ng-container matColumnDef="difference">
        <th mat-header-cell *matHeaderCellDef class="table-number"> Difference </th>
        <td mat-cell *matCellDef="let expRow" class="table-number"> {{ expRow.result - expRow.calculated === 0 ? '' : expRow.result - expRow.calculated | number }} </td>
    </ng-container>

    <tr mat-header-row *matHeaderRowDef="displayedExpColumns"></tr>
    <tr mat-row *matRowDef="let expRow; columns: displayedExpColumns;">
    </tr>
</table>`

[crisbeto]

@JamieMcI just looking at the stack trace, it doesn't look like something coming from Material. At least in the table, we don't have any explicit calls to ngOnDestroy. If you can put together an example of it breaking I can take a look. You can fork some of the examples from the docs site as a starting point.

[JamieMcI]

Having trouble putting together an example, so I apologize if this isn't helpful. Wanted to give a quick update. Referencing this Stack overflow I set my build-optimizer = false. This fixed the issue.

The reason I reference this here is because 6.4.2 introduced the problem and the commit for this issue implements a new ngOnDestroy. This could just be my code base when the optimizer tries to combine the new code in 6.4.2 with my project. Not super clear on how the optimizer works.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}