feat(expansion-panel): add injection token for configuring the default options #14384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
14383/expansion-default-options
branch
from
b1e655a to
9f92167
Compare
|
I don't mind adding some, but it feels like we'd basically be testing DI. |
|
IMO it's about testing that the panel correctly pulls the default from the custom options |
…t options Adds a new injection token to allow people to configure the default options for the expansion panel component. Fixes angular#14383.
crisbeto
force-pushed
the
14383/expansion-default-options
branch
from
9f92167 to
82ab05f
Compare
|
@jelbourn I've added a test for the injection token. |
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…t options (angular#14384) Adds a new injection token to allow people to configure the default options for the expansion panel component. Fixes angular#14383.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new injection token to allow people to configure the default options for the expansion panel component.
Fixes #14383.