Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing mdCardHeader ng-content slot #6816

Closed
kherock opened this issue Sep 3, 2017 · 2 comments · Fixed by #6818
Closed

Missing mdCardHeader ng-content slot #6816

kherock opened this issue Sep 3, 2017 · 2 comments · Fixed by #6818
Assignees
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@kherock
Copy link
Contributor

kherock commented Sep 3, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Specifying an md-card with something like <h3 mdCardTitle>Shiba Inu</h3> should put it in the right slot in an md-card-header.

What is the current behavior?

The .mat-card-header-text element is empty, it should be selecting [mdCardTitle].

What are the steps to reproduce?

Providing a Plunker (or similar) is the best way to get the team to see your issue.
(Plunker templates aren't working right now)

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

material2 beta 10

Is there anything else we should know?

@julianobrasil
Copy link
Contributor

julianobrasil commented Sep 3, 2017

Have you tried md-card-title instead of mdCardTitle?

I've taken a quick look at some parts of the code and, though there's a directive named after mdCardTitle, the selectors in html template goes like this:

<ng-content
      select="md-card-title, mat-card-title, md-card-subtitle, mat-card-subtitle,
      [md-card-title], [mat-card-title], [md-card-subtitle], [mat-card-subtitle]">
</ng-content>

Edit: helpful reading => #6720

@crisbeto crisbeto self-assigned this Sep 3, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 3, 2017
Fixes the camel-cased selectors for `mdCardTitle` and `mdCardSubtitle` not being added to the content projection selector.

Fixes angular#6816.
@crisbeto crisbeto added the has pr label Sep 3, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 3, 2017
Fixes the camel-cased selectors for `mdCardTitle` and `mdCardSubtitle` not being added to the content projection selector.

Fixes angular#6816.
@crisbeto crisbeto added the P4 A relatively minor issue that is not relevant to core functions label Nov 28, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 23, 2018
Fixes the camel-cased selectors for `mdCardTitle` and `mdCardSubtitle` not being added to the content projection selector.

Fixes angular#6816.
jelbourn pushed a commit that referenced this issue Jan 24, 2018
Fixes the camel-cased selectors for `mdCardTitle` and `mdCardSubtitle` not being added to the content projection selector.

Fixes #6816.
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 29, 2018
)

Fixes the camel-cased selectors for `mdCardTitle` and `mdCardSubtitle` not being added to the content projection selector.

Fixes angular#6816.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants