-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): add camel-cased selectors to content projection #6818
Conversation
Shouldn't it also be changed in |
8eb696e
to
05957c1
Compare
Can I interject with one other related question? Shouldn't |
@crisbeto, once there's no |
@andrewseguin where did we leave off when we last talked about these? This was one of the special cases we said we'd figure out later |
I think we ought to sit down and look at the list of outstanding selectors we want to review to decide on how we move forward on it. Will bring it up with the team and see if we want to schedule something. With regard to this issue, looks like this fix needs to go in regardless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gotta rebase
Fixes the camel-cased selectors for `mdCardTitle` and `mdCardSubtitle` not being added to the content projection selector. Fixes angular#6816.
05957c1
to
b753de0
Compare
) Fixes the camel-cased selectors for `mdCardTitle` and `mdCardSubtitle` not being added to the content projection selector. Fixes angular#6816.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the camel-cased selectors for
mdCardTitle
andmdCardSubtitle
not being added to the content projection selector.Fixes #6816.
@jelbourn this seems along the same lines as #5647, should I get rid of the dash-cased selectors while I'm at it?