Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fluid resistance quantity #1474

Merged

Conversation

Jagailo
Copy link
Contributor

@Jagailo Jagailo commented Dec 27, 2024

https://en.wikipedia.org/wiki/Vascular_resistance

  1. I know that negative powers are not welcome, but for dyn·s/cm⁵ and dyn·s·cm⁻⁵ units I added 2 options because both are equally common.
  2. The unit MPa·s/m³ comes with the mega- prefix because that is the only combination that is used. I have not seen it as just Pa·s/m³ or in any other form.
  3. WhodUnit actually has 3 different abbreviations, but they all mean the same thing. For mmHg·min/l, translating popular units into Russian was not difficult, but for WU and HRU I had to improvise. WU - Wood Units, which in turn is translated as "Единицы Вуда" (Units of Wood), so two words in the Russian version have changed places, and the capital letters form ЕВ (WU = ЕВ). For HRU I translated Hybrid Resistance Unit and used the capital letters of the Russian version. Translated as "Единицы Гибридного Сопротивления" (HRU = ЕГС)

@Jagailo
Copy link
Contributor Author

Jagailo commented Jan 9, 2025

I have no more ideas why base SI doesn't work, so I removed these tests.

image

@Jagailo Jagailo requested a review from angularsen January 10, 2025 10:42
@Jagailo Jagailo changed the title Add vascular resistance quantity Added fluid resistance quantity Jan 12, 2025
Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question

@Jagailo Jagailo requested a review from angularsen January 19, 2025 23:38
@Jagailo
Copy link
Contributor Author

Jagailo commented Feb 1, 2025

@angularsen Sorry for pinging you, but is everything fine with this PR? Do I need to change anything else?

@angularsen angularsen merged commit de46d16 into angularsen:master Feb 2, 2025
1 check failed
@angularsen
Copy link
Owner

No problem, it helps with a reminder if it takes more than a few days. Weekdays are kinda busy for me, but I usually find time in the weekends for small PRs like this.

Thanks! Nuget should be on the way.

Release UnitsNet/5.68.0 · angularsen/UnitsNet

@Jagailo Jagailo deleted the add-vascular-resistance-quantity branch February 16, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants