-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor corrections to some unit abbreviations #1496
Minor corrections to some unit abbreviations #1496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements! A couple of suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, there are a couple of minor breaking changes here, but I'll risk it.
I think very few will be upset that we no longer support parsing *
or .
in these unit abbreviations. I'd rather have the parser use normalization or attempt a few fallbacks to cover such alternative formats.
I work in the medical domain and our users enter units by hand. |
AreaMomentOfInertia:
MolarEntropy:
SpecificEntropy:
Using parentheses for mathematically correct display; using the correct symbol for degrees Celsius
SpecificFuelConsumption:
It looks like some unusual multiplication sign was used
WarpingMomentOfInertia:
For ^4 and ^6 UnitParser.NormalizeUnitString() will handle this situation