Plural fix for accelerations #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angularsen
requested changes
May 5, 2018
| "XmlDoc": "Acceleration, in physics, is the rate at which the velocity of an object changes over time. An object's acceleration is the net result of any and all forces acting on the object, as described by Newton's Second Law. The SI unit for acceleration is the Meter per second squared (m/s²). Accelerations are vector quantities (they have magnitude and direction) and add according to the parallelogram law. As a vector, the calculated net force is equal to the product of the object's mass (a scalar quantity) and the acceleration.", | ||
| "Units": [ | ||
| { | ||
| "SingularName": "MeterPerSecondSquared", | ||
| "PluralName": "MeterPerSecondSquared", | ||
| "SingularName": "MetersPerSecondSquared", |
There was a problem hiding this comment.
Singular name should stay MeterPerSecondSquared.
|
|
||
| protected override double KnotsPerHourInOneMeterPerSecondSquared => 6.99784017278618E3; | ||
| protected override double KnotsPerHourInOneMetersPerSecondSquared => 6.99784017278618E3; |
There was a problem hiding this comment.
See below, singular name is used here so due to wrong singular name in JSON below it reads InOneMeters here.
|
A bit fat-fingered with find replace :) fixed |
|
Looks good ! :-) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.