Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnitsNet.NumberExtensions nuget #742

Merged
merged 23 commits into from
Feb 6, 2020
Merged

Conversation

luli0401
Copy link
Contributor

@luli0401 luli0401 commented Jan 22, 2020

Fixes #735.

This pull request is based on the discussion of issue #735.
Create new 'UnitsNet.Extensions' project which includes all the NumberToExtensions, and include this NuGet package in the build process.

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #742 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   62.95%   62.96%   +<.01%     
==========================================
  Files         270      270              
  Lines       39529    39539      +10     
==========================================
+ Hits        24886    24896      +10     
  Misses      14643    14643
Impacted Files Coverage Δ
UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs 100% <ø> (ø) ⬆️
UnitsNet/GeneratedCode/UnitConverter.g.cs 100% <100%> (ø) ⬆️
UnitsNet/GeneratedCode/Quantities/Force.g.cs 61.36% <100%> (+0.75%) ⬆️
...ensions/GeneratedCode/NumberToForceExtensions.g.cs 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214d2c9...862a84f. Read the comment docs.

Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's starting to look very good, a few comments.

@angularsen
Copy link
Owner

angularsen commented Jan 31, 2020 via email

Get the latest version from uptream
…a test project for extension methods, and improve the Extension project decription.
Sync the Extension project version number with the main library, add a test project for extension methods, and improve the Extension project description.
Fix the NuGet package name, and add new test project to the build pro…
Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good!
It's a bit hard to say for sure, there are a ton of changes here, but I've skimmed through it and can't find any obvious problems with it. I think we should just let it roll out and start playing with the new nuget 🎉

@angularsen angularsen changed the title 'NumberTo' Extensions Restoration Add UnitsNet.NumberExtensions nuget Feb 6, 2020
@angularsen angularsen merged commit fc6f06b into angularsen:master Feb 6, 2020
@angularsen
Copy link
Owner

@luli0401 And it's live! :-)

https://www.nuget.org/packages/UnitsNet.NumberExtensions/4.44.0

I did a quick test referencing the nuget and it works as expected 🎉

@luli0401
Copy link
Contributor Author

luli0401 commented Feb 6, 2020

@luli0401 And it's live! :-)

https://www.nuget.org/packages/UnitsNet.NumberExtensions/4.44.0

I did a quick test referencing the nuget and it works as expected 🎉

I saw that, excellent!
Thank you for all your help.

@angularsen
Copy link
Owner

And thank you for the great work 😀 It was solid.

@angularsen
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoration of Extension Methods
6 participants