-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnitsNet.NumberExtensions nuget #742
Conversation
Update to the latest version
Forgot to include release note about supporting arrays.
… add the version bump scripts.
Restore 'NumberTo' extensions
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
==========================================
+ Coverage 62.95% 62.96% +<.01%
==========================================
Files 270 270
Lines 39529 39539 +10
==========================================
+ Hits 24886 24896 +10
Misses 14643 14643
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's starting to look very good, a few comments.
UnitsNet.Extensions.Tests/NumberToExtensions/NumberExtensionsTest.cs
Outdated
Show resolved
Hide resolved
UnitsNet.Extensions/GeneratedCode/NumberToExtensions/NumberToAccelerationExtensions.g.cs
Outdated
Show resolved
Hide resolved
Perfect :-)
|
Get the latest version from uptream
…a test project for extension methods, and improve the Extension project decription.
Sync the Extension project version number with the main library, add a test project for extension methods, and improve the Extension project description.
Fix the NuGet package name, and add new test project to the build pro…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good!
It's a bit hard to say for sure, there are a ton of changes here, but I've skimmed through it and can't find any obvious problems with it. I think we should just let it roll out and start playing with the new nuget 🎉
UnitsNet.NumberExtensions.Tests/GeneratedCode/NumberToAccelerationExtensionsTest.g.cs
Show resolved
Hide resolved
Added kilopound-force imperial variant to force (angularsen#747)
@luli0401 And it's live! :-) https://www.nuget.org/packages/UnitsNet.NumberExtensions/4.44.0 I did a quick test referencing the nuget and it works as expected 🎉 |
I saw that, excellent! |
And thank you for the great work 😀 It was solid. |
Fixes #735.
This pull request is based on the discussion of issue #735.
Create new 'UnitsNet.Extensions' project which includes all the NumberToExtensions, and include this NuGet package in the build process.