-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete multiple videos at once #756
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # core/ui/src/main/res/values/strings.xml
@Yashraj254, thank you for the pull request, and I'm sorry for not getting back to you sooner. Your work looks really good. I have a small suggestion regarding the user interface: instead of using square checkboxes, could you use circular ones? Also, for items that are not selected, we don't need any checkbox at all. Additionally, I think it would improve the appearance if we added a highlighted background for selected videos to make them more noticeable. |
It's alright, I will implement those changes. In the meantime, could you please review my other PRs? |
Does this look better or should i use a different color, any suggestions? sample2.mp4 |
This is a very useful feature, but its not available yet in the main build? |
@anilbeesetti any update on getting this merged with the latest changes? |
Fix: #688 featured added: select multiple videos for deletion
Record_2023-11-17-14-27-31.1.mp4