Refactor image generation for easier configuration #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prefer config over system information. This fixes multi screen
issues.
- Only generate one image and use WordCloud's API to account for the
margin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On a system with multiple screens the wallpaper was still generated with the resolution of only one of the screens. E.g. For three
1920x1080screens the wallpaper had a resolution of1920x1080instead of5760x1080. Changing theconfig.yamldidn't help. This PR fixes this issue.Also the generation of the intermediate image was removed as it is not necessary.
Changes
Additional Information
Maybe it would be nice to expose more config parameters of WordCloud via the
config.yaml.