Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most capital inconsistencies across languages and update guidelines #435

Merged
merged 9 commits into from
Jul 5, 2021

Conversation

axelboc
Copy link
Collaborator

@axelboc axelboc commented Jul 4, 2021

Fix #416 - FYI, I'll open separate issues to deal with the remaining inconsistencies that I have decided not to fix in this PR, namely Sri Lanka, Kiribati, Northern Cyprus and European Union.


First off, I update the capital field guidelines as per #416 (comment), to make English Wikipedia the source of truth for capitals in all languages (except for spelling and alternative names, of course).

Then, I fix the following inconsistencies in separate commits:

[DE] Move alternative spelling of capital of Burkina Faso to capital info field

  • "Ouagadougou (Wagadugu)" becomes "Ouagadougou".
  • The country info field now contains "Auch Wagadugu".

[ES] Remove honorary capital of Montenegro

  • "Podgorica, Cetiña" becomes "Podgorica".
  • I remove Podgorica from the capital info field, and reword the sentence about "Cetiña" very slightly ("una capital" instead of "la capital") for consistency with other languages. @josealberto4444

[FR] Change capital of Palau

[NL] Re-order capitals of South Africa

[NB] Rename capital of Kazakhstan

[NB] Remove alternative name for capital of Finland

  • "Helsingfors (Helsinki)" becomes "Helsingfors".
  • I also reword the capital info slightly, so the spelling "Helsinki" doesn't appear out of the blue. @Vages

[NB] Remove parens in capitals of Chile and Colombia

[NB] Remove alternative capital of Tuvalu

  • "Vaiaku/Funafuti" becomes "Funafuti".
  • This change can be justified by both the new guidelines and by SNL now being the main translation source: https://snl.no/Tuvalu
  • I've removed the capital info completely as I no longer think it's relevant.

English Wikipedia is now the source of truth of capitals (except for spelling/alternative names).
@josealberto4444
Copy link
Collaborator

I think the sentence looks good in Spanish like that, thank you!

However, maybe we should consider following other capital info formulations and write "While Podgorica is the official capital, Cetinje is the honorary capital". For me, it's strange showing an official capital in the capital field and talking about other capital without the usual context found in other cards. Should I open an issue instead of discussing this here?

@axelboc
Copy link
Collaborator Author

axelboc commented Jul 4, 2021

Should I open an issue instead of discussing this here?

Yeah, might be easier 👍

Copy link
Collaborator

@aplaice aplaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic!

Other than two formatting nitpicks (we no longer have a composer index to keep us on our toes...) and a suggested change to the Norwegian Kazakhstan capital info, I have nothing to add.


Pretoria was listed second, which was inconsistent with other languages and also with Dutch Wikipedia: https://nl.wikipedia.org/wiki/Zuid-Afrika

Interestingly, the capital info already had them in the "consistent" order.

src/data/capital.csv Outdated Show resolved Hide resolved
src/data/capital.csv Outdated Show resolved Hide resolved
src/data/capital_info.csv Outdated Show resolved Hide resolved
@MaloMn
Copy link

MaloMn commented Jul 5, 2021

Looks incredible! Thanks!

src/data/capital_info.csv Outdated Show resolved Hide resolved
axelboc added 8 commits July 5, 2021 19:52
SNL, the main translation source, has made the switch from Astana to Nursultan: https://snl.no/Kasakhstan
... to match order in other languages and on Dutch Wikipedia : https://nl.wikipedia.org/wiki/Zuid-Afrika
SNL, now the main translation source, cites "Santiago de Chile" as the capital of Chile, and " Bogotá" as the capital of Colombia.
As per new cross-language consistency guidelines. Note, however, that SNL (now the main translation source) lists only Funafuti as the capital, not Vaiaku.
@axelboc axelboc force-pushed the capital-inconsistencies branch from b8168b4 to 77068a9 Compare July 5, 2021 17:54
@axelboc
Copy link
Collaborator Author

axelboc commented Jul 5, 2021

Nice, thanks a lot! 🎣

@axelboc axelboc merged commit a0db20c into master Jul 5, 2021
@axelboc axelboc deleted the capital-inconsistencies branch July 5, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Capital inconsistencies between languages [FR] Melekeok vs Ngerulmud as capital of Palau
5 participants