-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectorize flags #577
Vectorize flags #577
Conversation
I have now. 😅 Thanks for reminding me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They look much better than the old PNGs, thanks 🤩
Thanks! I think that these should, ideally, have their height changed to 250 px and the width adjusted accordingly. (Otherwise, the images will appear huge when reviewing. (Modifying the SVG as opposed to specifying the height with CSS has, I think, the advantage that the images will also look consistent (and not huge) in the editor/browsing pane.) Just editing
One other very minor issue (which I realised while looking at #220) is that now, if one zooms in, the name of the Dominican Republic is visible. Hence, in the longer run, it might be also worth blurring. |
@aplaice, thank you for correcting the widths and heights, plus adding the viewBoxes. |
This PR will vectorize the following flags:
The following flags still need to be vectorized:
These flags were not vectorized because they also needed to be blurred:
and these flags because they didn't correspond to the first flag on Wikipedia, which I thought was the consensus based on #111: