Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump protobuf-gradle-plugin from 0.8.19 to 0.9.0 #238

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 7, 2022

Bumps protobuf-gradle-plugin from 0.8.19 to 0.9.0.

Release notes

Sourced from protobuf-gradle-plugin's releases.

v0.9.0 is released

Fixed bugs

  • Workaround provider bug in Gradle when excluding tasks (#576). Errors were of the form Querying the mapped value of provider(interface java.util.Set) before task ':project:processResources' has completed is not supported

Improvements

  • Improved Kotlin accessor support for Android Gradle Plugin 7.x, which uses a different SourceSet class (#565, fixes #540)
  • Migrated project.protobuf from a convention to an extension (#577). This greatly improves the Kotlin experience, as fewer imports are necessary. On upgrade, kts users will need to remove any now-unnecessary imports from their scripts
  • Significantly improve support for task configuration avoidance. README.md has not yet been updated to encourage using configureEach instead of each within generateProtoTasks {}, but it is beneficial as long as you are not using any IDE plugins
  • Added generated code to java SourceSet instead of only adding it to JavaCompile and related tasks. This should cause tasks like sourcesJar to now include the generated code
  • Added Eclipse and VSCode support (#590). They should no longer have trouble finding generated code
  • Removed references to unused Gradle-internal FileResolver (#595)
  • Removed usage of deprecated GUtil (#604)
  • Removed dependency on Apache commons-lang (#606)
  • Removed dependency on Guava (#609)
  • Upgraded osdetector-gradle-plugin to 1.7.1
  • Substantial internal modernization. This should not impact most users, but there is risk of a regression or observing timing differences.

Thanks to contributors

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [protobuf-gradle-plugin](https://github.com/google/protobuf-gradle-plugin) from 0.8.19 to 0.9.0.
- [Release notes](https://github.com/google/protobuf-gradle-plugin/releases)
- [Commits](google/protobuf-gradle-plugin@v0.8.19...0.9)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 7, 2022
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit.

@mikehardy mikehardy added the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Oct 7, 2022
@mikehardy
Copy link
Member

Huh. Well that's unexpected.


* What went wrong:
Execution failed for task ':rsdroid:generateReleaseProto'.
> protoc: stdout: . stderr: [libprotobuf WARNING src/google/protobuf/compiler/parser.cc:646] No syntax specified for the proto file: .clang-format. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
  .clang-format:1:1: Expected top-level statement (e.g. "message").

@dae
Copy link
Contributor

dae commented Oct 9, 2022

There are two dotfiles in anki/proto that seem to no longer be being ignored

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 10, 2022

Superseded by #239.

@dependabot dependabot bot closed this Oct 10, 2022
@dependabot dependabot bot deleted the dependabot/gradle/com.google.protobuf-protobuf-gradle-plugin-0.9.0 branch October 10, 2022 17:16
@mikehardy mikehardy removed the pending-merge Waiting on CI or question responses to merge, but otherwise ready label Oct 10, 2022
@mikehardy
Copy link
Member

Yeah, they issued a patch that fixes it: google/protobuf-gradle-plugin#621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants