-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup]: Remove Android Studio Warning #18042
[Cleanup]: Remove Android Studio Warning #18042
Conversation
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for contributing. Left one minor issue and a question: judging by the approach section, are there other changes that were not included?
No there were no other changes in mind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but please squash the two commits into a single commit. Then this can be merged.
d6ebf7b
to
2079ea1
Compare
Thanks! |
Purpose / Description
Optimizing function calls by converting arguments to
Set
for improved performance and reducing warnings.Fixes
Approach
Iterable<T>
andArray<T>
arguments toSet<T>
to enhance efficiency inminus
andintersect
operations.UniqueArrayList.kt
to improveremoveAll
andretainAll
performance.test_retainAll()
inUniqueArrayListTest.kt
to usesetOf()
for better efficiency.Checklist
Please, go through these checks before submitting the PR.