Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show Backup prompt dialog if there is no one-way or auto sync at startup #18056

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arooooon
Copy link
Contributor

@arooooon arooooon commented Mar 4, 2025

Purpose / Description

Issue: When starting the app, sometimes you can get a Backup reminder dialog at the same time that autosync kicks in.

ankiAutoSyncDialog.mp4

Fixes

I didn't make an issue as this problem was mentioned in a comment in this issue . But I think that issue is broader than what is fixed in this PR.

Approach

Not showing the backup reminder dialog if one-way sync dialog should be shown or if AutoSync triggered a sync.

How Has This Been Tested?

This issue can be simulated by:

  1. Enabling AutoSync
  2. Set BackupPromptDialog.shouldShowDialog() to always return true.
  3. Set DeckPicker.syncIntervalPassed() to always true
  4. review a card
  5. Open the app again.

Tested by restarting the app with and without making changes to review data so that syncing is performed, respectively not performed.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant