What did I get myself into... #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You‘re sure you‘re not over complicating things? |
|
no |
|
This branch builds again at least. (Don't talk about the tests) What underwent major changes
Problems
I can't believe I did this just because I hated the GithubClientProvider with the static client so much. |
|
Converters work now. After configuring the services, They are added to the resource dictionaries in code behind. I know, it's hacky, but it works. @jakobharder you decide, if it's worth fixing the tests, I'll do it. If it's not worth, this branch can be scrapped. |
|
Okay, branch works and the subfolder thing is also in there. Make or break, this gonna get merged or nuked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency injection is easy they said... it will be much fun they said..