Rename ∘ to << and add >>, |> and <| functions #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
composition-application
branch
from
085540e to
826f67e
Compare
paulcadman
force-pushed
the
composition-application
branch
from
88449d1 to
290f67f
Compare
lukaszcz
reviewed
Jun 24, 2024
Stdlib/Data/List/Base.juvix
Outdated
| @@ -219,7 +219,7 @@ syntax iterator concatMap {init := 0; range := 1}; | |||
| --- Applies a function to every item on a ;List; and concatenates the result. | |||
| --- 𝒪(𝓃), where 𝓃 is the number of items in the resulting list. | |||
| concatMap {A B} (f : A -> List B) : List A -> List B := | |||
| flatten ∘ map f; | |||
| flatten << map f; | |||
There was a problem hiding this comment.
Since we have >>, I think it would be more readable to use it in most situations instead of << (the composition order of >> from left to right seems more intuitive: we first map, then flatten).
There was a problem hiding this comment.
Agreed - I will change this. Thanks
lukaszcz
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the unicode composition function name with
<<and adds similar functions>>,|>and<|. Inspired by elm.The
$function is now called<|.The
>>>(builtin seq) function is now called>->.The
>> : IO -> IO -> IOfunction is now called>>>.