Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute name dependency graph and filter unreachable definitions #1408

Merged
merged 8 commits into from
Jul 25, 2022
Merged

Compute name dependency graph and filter unreachable definitions #1408

merged 8 commits into from
Jul 25, 2022
+469 −9

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Jul 21, 2022 •
edited
Loading

Description

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works:
    • Negative tests
    • Positive tests
    • Shell tests

Sorry, something went wrong.

@lukaszcz lukaszcz changed the title Compute name dependency graph and filter unreachable declarations Compute name dependency graph and filter unreachable definitions Jul 21, 2022
@lukaszcz lukaszcz added this to the 0.2.3 milestone Jul 21, 2022
@lukaszcz lukaszcz self-assigned this Jul 21, 2022
@jonaprieto jonaprieto marked this pull request as draft July 21, 2022 16:55
@lukaszcz lukaszcz marked this pull request as ready for review July 22, 2022 14:54
@jonaprieto jonaprieto modified the milestones: 0.2.3, 0.2.2 Jul 25, 2022
@jonaprieto jonaprieto requested review from jonaprieto and janmasrovira and removed request for jonaprieto July 25, 2022 08:16
@lukaszcz lukaszcz force-pushed the 1383-dependency-graph branch from 7213d4f to 908b73f Compare July 25, 2022 14:23
janmasrovira
janmasrovira reviewed Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@janmasrovira janmasrovira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review in progress

@jonaprieto jonaprieto added the enhancement New feature or request label Jul 25, 2022
@lukaszcz lukaszcz force-pushed the 1383-dependency-graph branch from cdc3720 to 58123e5 Compare July 25, 2022 15:59
janmasrovira
janmasrovira reviewed Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@janmasrovira janmasrovira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last style change that I missed earlier

jonaprieto
jonaprieto approved these changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@jonaprieto jonaprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!

@jonaprieto jonaprieto merged commit 4c5fee3 into main Jul 25, 2022
@jonaprieto jonaprieto deleted the 1383-dependency-graph branch July 25, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira

@jonaprieto jonaprieto

Assignees

@lukaszcz lukaszcz

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.

Recognising unused functions should be done earlier in the pipeline
3 participants
@lukaszcz @jonaprieto @janmasrovira