Permit axiom without a compile block #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
axiom-no-compile-1417
branch
from
208d0c8 to
08cbaf7
Compare
jonaprieto
approved these changes
Jul 27, 2022
An axiom without a compile block generates a C function signature without a corresponding body. This allows implementations to be injected at link time (JS, Anoma).
jonaprieto
force-pushed
the
axiom-no-compile-1417
branch
from
08cbaf7 to
e34615e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An axiom without a compile block generates a C function signature
without a corresponding compile block body. This allows implementations to be injected
at link time (JS, Anoma).
It's hard to test this change until we can give exported symbols stable names. When this is in place we can write tests that inject implementations of axioms.
So this PR includes a test that the compiler doesn't throw an error when an axiom is encountered without a corresponding compile block.
Closes #1417
Closes #1388