Back recursor types with type families #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
requested changes
Sep 6, 2022
janmasrovira
force-pushed
the
recursors-with-type-families
branch
from
0cb2df7 to
d461894
Compare
lukaszcz
previously approved these changes
Sep 6, 2022
janmasrovira
force-pushed
the
recursors-with-type-families
branch
from
c5f6cc8 to
254b0f3
Compare
lukaszcz
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we explore the use of type families to improve the reliability of all the map variations for the Node type. We may want to the the same for the fold variations in the future.
After discussing the topic we agreed that we would keep type families as part of the implementation but we would also expose a list of functions with concrete types and mnemonic names.
Also, I have renamed
Monadic->MapandApplicative->Fold. I think it makes more sense like this.