Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CLI #1527

Merged
merged 13 commits into from
Sep 14, 2022
Merged

Refactor CLI #1527

merged 13 commits into from
Sep 14, 2022

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Sep 9, 2022

Maintenance refactor of the app/ subtree.

Changes include:

  1. commands are separated into modules to make it less cluttered.
  2. Input files are no longer a global option, so completion and help work as intended.
  3. Completion for input juvix files only suggest .juvix files.
  4. Global flags must be given before any subcommand.
  5. Now --output and --output-dir work with respect to where juvix is called and not the root of the project.
  6. internal subcommand renamed to dev. It now shows in the utility commands help section instead of the compiler commands section.

@janmasrovira janmasrovira linked an issue Sep 9, 2022 that may be closed by this pull request
@janmasrovira janmasrovira changed the title Refactor CLI (#1406) Refactor CLI Sep 9, 2022
@janmasrovira janmasrovira self-assigned this Sep 9, 2022
@janmasrovira janmasrovira added this to the 0.2.5 milestone Sep 9, 2022
@janmasrovira janmasrovira marked this pull request as ready for review September 13, 2022 17:50
lukaszcz
lukaszcz previously approved these changes Sep 14, 2022
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - autocompletion of input filenames works again 🥳

@janmasrovira janmasrovira merged commit 60d4f04 into main Sep 14, 2022
@janmasrovira janmasrovira deleted the 1406-refactor-cli branch September 14, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CLI
3 participants