Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Cairo VM input hints #2709

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Support Cairo VM input hints #2709

merged 11 commits into from
Apr 9, 2024

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Apr 3, 2024 •
edited
Loading

  • Closes Support input to Cairo programs #2687
  • Adds hint support in CASM. The supported hints are Input(var) and Alloc(size). These are the hints currently implemented in juvix-cairo-vm.
  • Adds the --program_input option to the juvix dev casm run command.
  • Enables private inputs via main arguments. In generated CASM/Cairo code, the arguments to main are fetched using the Input hint.
  • Modifies the CI to use juvix-cairo-vm

@lukaszcz lukaszcz added the cairo label Apr 3, 2024
@lukaszcz lukaszcz added this to the 0.6.2 milestone Apr 3, 2024
@lukaszcz lukaszcz self-assigned this Apr 3, 2024
@lukaszcz lukaszcz marked this pull request as ready for review April 5, 2024 10:02
@lukaszcz lukaszcz mentioned this pull request Apr 5, 2024
Merged
janmasrovira
janmasrovira reviewed Apr 8, 2024
View reviewed changes
app/Commands/Dev/Casm/Run/Options.hs Outdated Show resolved Hide resolved
src/Juvix/Compiler/Casm/Data/InputInfo.hs Outdated Show resolved Hide resolved
src/Juvix/Compiler/Casm/Translation/FromSource.hs Outdated Show resolved Hide resolved
app/Commands/Dev/Casm/Run.hs Outdated Show resolved Hide resolved
@lukaszcz lukaszcz requested a review from janmasrovira April 8, 2024 15:03
@janmasrovira
Copy link
Collaborator

@lukaszcz there is one comment pending

@lukaszcz lukaszcz merged commit 651875e into main Apr 9, 2024
4 checks passed
@lukaszcz lukaszcz deleted the cairo-input branch April 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira janmasrovira approved these changes

@paulcadman paulcadman Awaiting requested review from paulcadman

Assignees

@lukaszcz lukaszcz

Labels
cairo
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

Support input to Cairo programs
2 participants
@lukaszcz @janmasrovira