-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize import syntax #2819
Merged
Merged
Generalize import syntax #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
changed the title
Add suport for `import A as B public;
Add suport for Jun 8, 2024
import A as B public
janmasrovira
force-pushed
the
2429-public-qualified-import
branch
from
June 8, 2024 09:45
6bfa417
to
3a165c0
Compare
janmasrovira
changed the title
Add suport for
Add suport for Jun 8, 2024
import A as B public
import A public
and import A as B public
janmasrovira
changed the title
Add suport for
Generalize import syntax
Jun 8, 2024
import A public
and import A as B public
janmasrovira
force-pushed
the
2429-public-qualified-import
branch
from
June 8, 2024 12:44
3a165c0
to
34a8239
Compare
janmasrovira
force-pushed
the
2429-public-qualified-import
branch
4 times, most recently
from
June 20, 2024 20:02
25d0e5a
to
2d92db1
Compare
lukaszcz
reviewed
Jun 21, 2024
@@ -1,55 +0,0 @@ | |||
module DefaultValues; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this test removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no test that used this file. It was basically an isolated file, so I removed it
lukaszcz
approved these changes
Jun 21, 2024
lukaszcz
force-pushed
the
2429-public-qualified-import
branch
from
June 21, 2024 12:03
dee113d
to
90e2789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces two enchancements to import statements:
using/hiding
list of symbols, with a behaviour analogous to the open statement.using/hiding
modifier and open statements with the expected behaviour.