Migrate old named application syntax #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
2668-remove-old-named-application-syntax
branch
5 times, most recently
from
d5c3775 to
9615266
Compare
janmasrovira
force-pushed
the
2668-remove-old-named-application-syntax
branch
from
a42c127 to
c24d1df
Compare
janmasrovira
force-pushed
the
2668-remove-old-named-application-syntax
branch
from
82f7175 to
54a7708
Compare
janmasrovira
changed the title
janmasrovira
force-pushed
the
2668-remove-old-named-application-syntax
branch
from
6dbe5c9 to
125fdcc
Compare
janmasrovira
force-pushed
the
2668-remove-old-named-application-syntax
branch
from
125fdcc to
9f8fe1f
Compare
paulcadman
reviewed
Jul 12, 2024
paulcadman
approved these changes
Jul 12, 2024
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr migrates the old named application syntax to the new one. In order to migrate a juvix file to the new syntax it suffices to run the formatter.
After the next release, we should completely remove the support for the old syntax.
Other changes
I've improved Scope negative tests. Previously, when a negative test failed, you could only see the title of the test and the message "Incorrect Error", as well as the Haskell file and line where the test is defined.
This is extremely incovenient because you have to go to the haskell test file, go to the line where the error is defined, look at the name of the file and then visit that file. Moreover, you need to manually run the scoper on that file to see the error that was returned.
I've fixed that and it now shows all relevant information. Example:
I've implemented this only using the
Genericinstance for theScoperErrortype, so doing something similar for the rest of negative tests should be straightforward.