Fix nock compilation and builtin evaluation of sha256 stdilb #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A sha256 hash is 32 bytes, not 64 bytes.
The builtin nock evaluator must match the behaviour of the anoma nock evaluator
lukaszcz
previously approved these changes
Nov 14, 2024
janmasrovira
previously approved these changes
Nov 14, 2024
The output of sha256 hash is no longer Base16 encoded
paulcadman
dismissed stale reviews from janmasrovira and lukaszcz
via
a4562ed
|
I forgot to update the other sha256 tests, this is now done. |
janmasrovira
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
A sha256 hash is 32 bytes long, not 64 bytes. This number is used when constructing the ByteArray representation (i.e
[length payload]cell) of the output of Anoma stdlib sha256 call. The Anoma stdlib sha256 call just returns the atom payload.Previously we were converting the sha256 hash bytestring to Base16 format. This is convenient when displaying the ByteString hash. However the Anoma nock interpreter outputs the raw bytes so we must change the builtin evaluator to match this behaviour.
After these fixes we can re-enable the test084 anoma compilation test.