Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds rust toolchain file for lsp purposes #276

Closed
wants to merge 1 commit into from
Closed

Conversation

grarco
Copy link

@grarco grarco commented Feb 14, 2025

No description provided.

@grarco grarco requested a review from sug0 February 14, 2025 14:22
Copy link
Contributor

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding a new file, can you point rust-toolchain to rust-stable-version? basically, create a symbolic link, instead of a new file.

this will make maintenance easier. the goal is to change the least amount of files possible in order to upgrade to a new rust toolchain, in the future.

ideally, we shouldn't even push these kinds of files, IMO. we can add them to the local ignore list (.git/info/exclude). this is what I use for *.vim files:

# git ls-files --others --exclude-from=.git/info/exclude
# Lines that start with '#' are comments.
# For a project mostly in C, the following would be a good set of
# exclude patterns (uncomment them if you want to use them):
# *.[oa]
# *~

/*.vim

@grarco
Copy link
Author

grarco commented Feb 17, 2025

Got you, I'm closing this pr then

@grarco grarco closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants