Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol balance change events #84

Closed
Tracked by #2530
tzemanovic opened this issue Feb 28, 2022 · 2 comments · Fixed by #3141
Closed
Tracked by #2530

protocol balance change events #84

tzemanovic opened this issue Feb 28, 2022 · 2 comments · Fixed by #3141
Assignees
Labels
ledger pre-mainnet Must happen before mainnet.

Comments

@tzemanovic
Copy link
Member

The ledger should attach an event to blocks in which some accounts' balances are modified by the protocol (e.g. wrapper tx fee charges, PoS slashing, future governance proposal refunds), to make the changes externally visible and index-able.

@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@cwgoes
Copy link
Collaborator

cwgoes commented Jan 12, 2023

@tzemanovic do you know the current status of this?

@tzemanovic
Copy link
Member Author

@tzemanovic do you know the current status of this?

This is still open. We do have events that replaced tendermint ones from #587 now, which should help a lot

@cwgoes cwgoes added the pre-mainnet Must happen before mainnet. label Feb 5, 2024
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
* Begin setting up KeyRing & accounts storage

* Adding a simple typed state class to keyring

* Address helper to obtain ImplicitAddress, cargo update

* Continue hooking up KeyRing to services

* Fix broken imports, confirm message works in popup

* Adding msg type for fetch generated mnemonic, update tests

* Beginning components package; get styled-components with theme working

* Disable devtool sourcemapping, add plugin for extension reloading (all browsers)

* Properly include svg assets, port additional components into shared
package

* Fix issue on reloader plugin

* fix module resolution, clean up imports

* Remove unnecessary assignment

* Consolidate types from Keplr into our own

* Validate mnemonic phrase before storing, better error handling in wasm

* Minor clean up, better type State class so as not to instantiate
directly

* Adding mnemonic/password creation screens, added README for types

* Split set-up flow into new tab for initial account

* Begin wiring up account derivation in service, generate implicit address
to store and return

* Add account derivation to completion process, load and display accounts

* Better error-handling, add user feedback on account creation

* Adding AccountListing components

* Clean up configs, layout, fixed bug in key storage

* Improved naming conventions, add implementation for scrypt, tests

* Implement optional custom Scrypt params

* Updated documentation

* Add aes dependency, being basic implementation

* KeyRing state is no longer duplicated, storage is only source of truth

* Add icon for copy to clipboard, additional styling, update styled config

* description -> alias to match cli, clean up

* Adding UI for adding a new derived account with basic validation

* Fix bug where alias is not being saved

* Add "alias" as a field during setup

* Updating for consistency, rough pass at styling derivation form

* Move path items to number, validate inputs, set primes appropriately

* Begin implementing kdf derived key as bytes

* Fix naming on file extension, begin components for password auth

* Add basic login/logout functionality, hook up to service backend

* Clean up effects, check keyring status on auth

* Fix minor bug when locking/unlocking wallet. Switch to numeric input

* Fix sourcemap warning, reuse lock button wrapper, minor style

* Update kdf libs for password hashing, tests, serializing params to
JsValue

* Add serializable struct and associated tests (params + bytes)

* Fix naming convention, create storage type containing params

* Moving storage updates to separate PR

* Clean up

* Remove unused dependencies in this branch

* 2 more dependencies that are unneeded

* Couple minor fixes that slipped through the cracks
@sug0 sug0 assigned sug0 and unassigned tzemanovic Mar 1, 2024
@sug0 sug0 added this to the To evaluate milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledger pre-mainnet Must happen before mainnet.
Projects
No open projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants