Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor governance events #3104

Merged
merged 76 commits into from
May 9, 2024
Merged

Refactor governance events #3104

merged 76 commits into from
May 9, 2024

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Apr 22, 2024

Describe your changes

Refactor governance events.

Indicate on which release or other PRs this topic is based on

Based on #3102

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman Fraccaman requested review from sug0 and grarco April 22, 2024 14:38
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 612 lines in your changes are missing coverage. Please review.

Project coverage is 59.61%. Comparing base (ea843f7) to head (cb2fef2).
Report is 7 commits behind head on main.

Files Patch % Lines
crates/ibc/src/event.rs 46.94% 113 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 88 Missing ⚠️
crates/events/src/extend.rs 73.96% 88 Missing ⚠️
crates/events/src/lib.rs 72.68% 62 Missing ⚠️
crates/governance/src/event.rs 54.38% 52 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 32 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 33.33% 24 Missing ⚠️
crates/sdk/src/events/log/dumb_queries.rs 82.75% 20 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 18 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs 16.66% 15 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3104      +/-   ##
==========================================
+ Coverage   59.41%   59.61%   +0.20%     
==========================================
  Files         298      300       +2     
  Lines       92326    92930     +604     
==========================================
+ Hits        54853    55400     +547     
- Misses      37473    37530      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left a comment

crates/governance/src/event.rs Show resolved Hide resolved
sug0
sug0 previously approved these changes Apr 23, 2024
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, that was my only real complaint.

btw make sure to rebase again, when this eventually is ready. I've changed the base a few times due to review comments, already, so your base has diverged from mine.

@Fraccaman
Copy link
Member Author

@sug0 can we cherry pick my commit to ur branch? its gonna make it easier

@sug0 sug0 force-pushed the fraccaman/governance-events branch from 9f92652 to f30c3ec Compare April 29, 2024 13:26
@sug0 sug0 force-pushed the fraccaman/governance-events branch from f30c3ec to ccc34a1 Compare April 30, 2024 10:16
@Fraccaman Fraccaman marked this pull request as ready for review April 30, 2024 12:35
brentstone added a commit that referenced this pull request Apr 30, 2024
* fraccaman/governance-events:
  changelog: add #3104
  goveranance: refactor and improve events
brentstone added a commit that referenced this pull request May 8, 2024
* origin/fraccaman/governance-events:
  changelog: add #3104
  goveranance: refactor and improve events
@brentstone brentstone merged commit f493796 into main May 9, 2024
16 of 19 checks passed
@brentstone brentstone deleted the fraccaman/governance-events branch May 9, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants