-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor governance events #3104
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3104 +/- ##
==========================================
+ Coverage 59.41% 59.61% +0.20%
==========================================
Files 298 300 +2
Lines 92326 92930 +604
==========================================
+ Hits 54853 55400 +547
- Misses 37473 37530 +57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that was my only real complaint.
btw make sure to rebase again, when this eventually is ready. I've changed the base a few times due to review comments, already, so your base has diverged from mine.
@sug0 can we cherry pick my commit to ur branch? its gonna make it easier |
Co-authored-by: yito88 <[email protected]>
9f92652
to
f30c3ec
Compare
f30c3ec
to
ccc34a1
Compare
* fraccaman/governance-events: changelog: add #3104 goveranance: refactor and improve events
* origin/fraccaman/governance-events: changelog: add #3104 goveranance: refactor and improve events
Describe your changes
Refactor governance events.
Indicate on which release or other PRs this topic is based on
Based on #3102
Checklist before merging to
draft