Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support invalid receivers in the IBC PFM flow #4134

Merged
merged 13 commits into from
Jan 20, 2025

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Dec 2, 2024

Describe your changes

Based on #4082

In order to be compatible with the Osmosis XCS contracts, which set invalid tnam1... addresses, we must disable validation of receivers, while handling PFM packets.

Diff: https://github.com/anoma/namada/compare/bat+tiago/feat/ibc-pfm..bat+tiago/feat/ibc-pfm-with-invalid-addrs

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 60.08230% with 194 lines in your changes missing coverage. Please review.

Project coverage is 74.53%. Comparing base (867e20d) to head (6e1a56e).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
crates/ibc/src/context/middlewares/pfm_mod.rs 52.63% 180 Missing ⚠️
crates/ibc/src/context/token_transfer.rs 63.63% 8 Missing ⚠️
crates/ibc/src/context/nft_transfer_mod.rs 33.33% 2 Missing ⚠️
crates/ibc/src/context/transfer_mod.rs 33.33% 2 Missing ⚠️
crates/ibc/src/lib.rs 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4134      +/-   ##
==========================================
- Coverage   74.59%   74.53%   -0.06%     
==========================================
  Files         342      344       +2     
  Lines      108796   109256     +460     
==========================================
+ Hits        81152    81433     +281     
- Misses      27644    27823     +179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sug0 added a commit that referenced this pull request Dec 18, 2024
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm-with-invalid-addrs branch from a404896 to a8ae15f Compare December 18, 2024 09:32
@sug0
Copy link
Collaborator Author

sug0 commented Dec 18, 2024

(rebased on latest main)

sug0 added a commit that referenced this pull request Dec 18, 2024
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm-with-invalid-addrs branch from a8ae15f to 570eb19 Compare December 18, 2024 14:46
@sug0 sug0 mentioned this pull request Dec 19, 2024
batconjurer pushed a commit that referenced this pull request Dec 27, 2024
sug0 added a commit that referenced this pull request Jan 13, 2025
@sug0 sug0 force-pushed the bat+tiago/feat/ibc-pfm-with-invalid-addrs branch from 570eb19 to d0a242f Compare January 13, 2025 13:19
sug0 and others added 6 commits January 20, 2025 15:20
@tzemanovic tzemanovic force-pushed the bat+tiago/feat/ibc-pfm-with-invalid-addrs branch from d0a242f to 6e1a56e Compare January 20, 2025 15:25
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 20, 2025
@mergify mergify bot merged commit 04b81b1 into main Jan 20, 2025
23 of 25 checks passed
@mergify mergify bot deleted the bat+tiago/feat/ibc-pfm-with-invalid-addrs branch January 20, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking: protocol breaking: tx IBC ledger merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants