Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes for v1.1.0 #4280

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Hermes for v1.1.0 #4280

wants to merge 7 commits into from

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jan 27, 2025

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.04%. Comparing base (a0cc88c) to head (aa952ad).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4280   +/-   ##
=======================================
  Coverage   74.04%   74.04%           
=======================================
  Files         345      345           
  Lines      110033   110033           
=======================================
+ Hits        81474    81479    +5     
+ Misses      28559    28554    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yito88
Copy link
Member Author

yito88 commented Jan 29, 2025

The new binary v1.10.5-namada-beta18 was built on Ubuntu 24lts. The CI is 22lts now and the execution error happened.

hermes: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.38' not found (required by hermes)

We can still use Hermes v1.10.4-namada-beta18-test3 for the CI. I reverted the Hermes version in the CI.

@yito88 yito88 requested a review from Fraccaman January 29, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant