Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #825
This PR makes it so that we pull in tendermint-related dependencies directly via a
git
source as we used before. e.g.This makes more sense as the namada code does hard depend on our forks, and doesn't work with upstream tendermint-rs packages. By specifying our forks as direct dependencies, there is no longer a need to patch in the correct versions via the workspace
Cargo.toml
s. Unfortunately we obscure the versions of our forks from ourCargo.toml
s, but the versions will still show up incargo tree
and when runningcargo build
,cargo check
, etc.The motivation for changing this in the first place was to make patching over tendermint-rs easier, but it is still possible to do this by patching one git source to a different once (see rust-lang/cargo#5478 for why this is required) although it is a bit hacky e.g.