Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output VPN Gateway FQDN #186

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Output VPN Gateway FQDN #186

merged 1 commit into from
Nov 11, 2024

Conversation

Xiol
Copy link
Contributor

@Xiol Xiol commented Nov 11, 2024

No description provided.

@Xiol Xiol requested a review from 0x4c6565 November 11, 2024 15:16
@Xiol Xiol self-assigned this Nov 11, 2024
0x4c6565
0x4c6565 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@0x4c6565 0x4c6565 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xiol Xiol merged commit d2a8ec3 into master Nov 11, 2024
1 check passed
@github-actions GitHub Actions
Copy link

Qodana for Go

3584 new problems were found

Inspection name Severity Problems
Unhandled error 🔶 Warning 2123
Unused parameter 🔶 Warning 187
Redundant types in composite literals 🔶 Warning 43
Deprecated element 🔶 Warning 6
Unused function 🔶 Warning 4
Unused exported function 🔶 Warning 3
Imported package name as a name identifier 🔶 Warning 2
Missing 'case' statements for 'iota' consts in 'switch' 🔶 Warning 2
Bool condition 🔶 Warning 1
Error string should not be capitalized or end with punctuation ◽️ Notice 972
Redundant import alias ◽️ Notice 194
Name starts with a package name ◽️ Notice 28
Type assertion on errors fails on wrapped errors ◽️ Notice 8
Redundant parentheses ◽️ Notice 4
Empty slice declared using a literal ◽️ Notice 3
Redundant type conversion ◽️ Notice 2
Type can be omitted ◽️ Notice 2

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4c6565 0x4c6565 0x4c6565 approved these changes

Assignees

@Xiol Xiol

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xiol @0x4c6565