update #1
Merged
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update ShopModel trait to use ShopId interface for value object * Update ShopModel interface to reference new ShopId interface * StyleCI fix * Move all remaining classes using ShopId to use the ShopId interface * StyleCI fixes * Updated Shop query contract to use ShopId interface * StyleCI fixes
* Some ITP code to test on live server * Added log * Completed ITP flow for testing * Cleanup of code for ITP. Removed unneeded config service and config trait. Moved config to a helper function * Cleanup for StyleCI * Modified Blade to access new helper for config * Fix to test suite to include ITP cookies for calls * Completed test suite for new ITP * Fix for styleCI
* Test PHP 8 support for Actions * Drop older Laravel versions * Exclude Laravel 7 from PHP 8 since Laravel 7 required ^7.2 * Use Laravel 8.22 as it supports PHP 8 and has no security reports * Fix version 8.0 to 8.22 for Actions
* Fix for Chrome and requestStorageAccess * Set manual cookie card to redirect back to app
Co-authored-by: Oleksii Savchuk <[email protected]>
Co-authored-by: Oleksii Savchuk <[email protected]>
Co-authored-by: Clyde Dexter Santiago <[email protected]>
* Fix for issue #742 * AuthShopify middleware: moved implode of data sources to own function * AuthShopify middleware: implode of data sources now handles array and nested arrays * SyleCI fix * Ignore data if no HMAC in AuthShopify middleware
* Added read shop from referrer if everything fails when using config_api_callback sometimes shop is just null if i click on an internal url of my app, but the information is present in the referrer * Fix undefined variable * Update ApiHelper.php Added header support * Update ApiHelper.php, style issue * Moved shop retrieve logic to private function * Update ApiHelper.php * Added shop parameter for config_api_callback * Fixed getShop default session value * Check shop with ShopDomain * Initialize variable * Added use for ShopDomain class * Fix code style * Cast to avoid exception * StyleCI Fixes * Check before converting $shop
…rs/create") (#868) * Add utility to convert REST webhook topic to GraphQL topic. Add test. * Convert webhook topic to GraphQL topic before creating the webhook * Show the GraphQL topic and actual webhook address in the output * Add more info to the `webhooks` config section comment * Only replace "Job" at the end of the job name
* Fix many docblocks. * Fix.
Turbulinks fixes
* Enable PHP-CS-Fixer. * Fix all code violations.
…ravel-shopify into lucasmichot-optimize-conditions
…el-shopify into lucasmichot-rename-variables
* Exclude file * Fix code
* Uses codecov. * Also fix PHPStan syntax. * Update URL.
* 🐛 Retain host parameter after successful install * Include host parameter in default view for appbridge 2.0 * Style violation Co-authored-by: Stephen Sweetland <[email protected]>
fixed ignoring installation the first time, will cause an installation failure next time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.