Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
tremble committed Jul 11, 2024
1 parent d14a517 commit c60147a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 11 deletions.
16 changes: 8 additions & 8 deletions changelogs/fragments/20240628-boto3_conn.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
breaking_changes:
- module_utils.botocore - ``boto3_conn``'s ``conn_type`` parameter is now mandatory ().
- module_utils.botocore - ``boto3_conn``'s ``conn_type`` parameter is now mandatory (https://github.com/ansible-collections/amazon.aws/pull/2157).
minor_changes:
- module_utils.botocore - the ``boto3_conn`` method now catches ``BotoCoreError`` rather than an incomplete list of subclasses ().
- plugin_utils.botocore - the ``boto3_conn`` method now catches ``BotoCoreError`` rather than an incomplete list of subclasses ().
- module_utils.botocore - replace use of ``botocore.Session`` with ``boto3.Session`` for consistency ().
trivial_changes:
- module_utils.botocore - added Type hints ().
- plugin_utils.botocore - added Type hints ().
- plugin_utils.base - added Type hints ().
- module_utils.botocore - the ``boto3_conn`` method now catches ``BotoCoreError`` rather than an incomplete list of subclasses (https://github.com/ansible-collections/amazon.aws/pull/2157).
- plugin_utils.botocore - the ``boto3_conn`` method now catches ``BotoCoreError`` rather than an incomplete list of subclasses (https://github.com/ansible-collections/amazon.aws/pull/2157).
- module_utils.botocore - replace use of ``botocore.Session`` with ``boto3.Session`` for consistency (https://github.com/ansible-collections/amazon.aws/pull/2157).
trivial:
- module_utils.botocore - added Type hints (https://github.com/ansible-collections/amazon.aws/pull/2157).
- plugin_utils.botocore - added Type hints (https://github.com/ansible-collections/amazon.aws/pull/2157).
- plugin_utils.base - added Type hints (https://github.com/ansible-collections/amazon.aws/pull/2157).
1 change: 0 additions & 1 deletion plugins/module_utils/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
import os
import re
import traceback
import typing
from io import StringIO
from typing import Any
from typing import Dict
Expand Down
1 change: 0 additions & 1 deletion plugins/plugin_utils/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from ansible.errors import AnsibleError
from ansible.module_utils.basic import to_native
from ansible.plugins import AnsiblePlugin
from ansible.utils.display import Display

from ansible_collections.amazon.aws.plugins.module_utils.botocore import check_sdk_version_supported
Expand Down
1 change: 0 additions & 1 deletion tests/unit/module_utils/botocore/test_aws_region.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from unittest.mock import MagicMock
from unittest.mock import PropertyMock
from unittest.mock import call
from unittest.mock import sentinel

Expand Down

0 comments on commit c60147a

Please sign in to comment.