ec2_eni idempotence bug #255
Comments
|
Files identified in the description:
If these files are inaccurate, please update the |
ansibullbot
added
bug
|
Hi, thank you for the bug report. Do you have an example of a problematical playbook? And would you like to submit a Pull Request? |
ansible-zuul bot
pushed a commit
that referenced
this issue
Jul 8, 2021
ec2_eni: Fix idempotency when security_groups is specified SUMMARY If security_groups attribute is specified - module always returns Changed = True. Fixes #255. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_eni ADDITIONAL INFORMATION Example: - amazon.aws.ec2_eni: name: my-eni security_groups: - my-sg subnet_id: subnet-123456 Will always return Changed = True. Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Sep 18, 2023
…n of creation (ansible-collections#1822) cloudfront_distribution: no longer crashes when waiting for completion of creation SUMMARY Fixes ansible-collections#255 Here we were referring to the ["Id"] member of a queried distribution, but there is level of embedding missing: ["Distribution"]["Id"] (Just how it's used here ) ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Sep 18, 2023
…n of creation (ansible-collections#1822) cloudfront_distribution: no longer crashes when waiting for completion of creation SUMMARY Fixes ansible-collections#255 Here we were referring to the ["Id"] member of a queried distribution, but there is level of embedding missing: ["Distribution"]["Id"] (Just how it's used here ) ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Oct 24, 2023
…n of creation (ansible-collections#1822) cloudfront_distribution: no longer crashes when waiting for completion of creation SUMMARY Fixes ansible-collections#255 Here we were referring to the ["Id"] member of a queried distribution, but there is level of embedding missing: ["Distribution"]["Id"] (Just how it's used here ) ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SUMMARY
The encoding of groups causes a bytes type does not equal a string type so idempotence fails. This is the line at fault I belive: https://github.com/ansible-collections/amazon.aws/blame/ac6b2cd478773befdde43bfadc0de40969ad4d0b/plugins/modules/ec2_eni.py#L772
ISSUE TYPE
COMPONENT NAME
ec2_eni
ANSIBLE VERSION
STEPS TO REPRODUCE
Pass security group names to the ec2_eni module & it will always report a change.
EXPECTED RESULTS
It should not report a change.
The text was updated successfully, but these errors were encountered: