Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxresults in ec2_snapshot_info #312

Closed
asifiqbal opened this issue Mar 29, 2021 · 7 comments
Closed

maxresults in ec2_snapshot_info #312

asifiqbal opened this issue Mar 29, 2021 · 7 comments
Labels
module module needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type)

Comments

@asifiqbal
Copy link

SUMMARY

Add maxresults (https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeSnapshots.html) to avoid filling up register. I have nearly 80k snapshots

ISSUE TYPE
  • an attribute maxresults
COMPONENT NAME

ec2_snapshot_info

ADDITIONAL INFORMATION

I could use maxresults: 100 so the output can fit into my register: results

---
- hosts: localhost
  gather_facts: no

  tasks:
     - amazon.aws.ec2_snapshot_info:
             filters:
                "tag:project": myproject
             maxresults: 100
       register: results
     - debug: var=results
   
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@asifiqbal: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) labels Mar 29, 2021
@asifiqbal
Copy link
Author

ansible 2.9.13
config file = /data/asif/ansible/ansible.cfg
configured module search path = ['/home/acag-asif.iqbal/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
executable location = /usr/local/bin/ansible
python version = 3.6.8 (default, Aug 13 2020, 07:46:32) [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)]

@goneri
Copy link
Member

goneri commented Apr 7, 2021

This sounds like a good idea. @tremble, @jillr Do we have a standardized name of a key like this?

@tremble
Copy link
Contributor

tremble commented Apr 7, 2021

max_results would be consistent with our normal naming. However, you'd also want to include the next_token parameter.

@abikouo abikouo added WIP Work in progress and removed needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels Apr 9, 2021
@abikouo abikouo self-assigned this Apr 9, 2021
@ansibullbot ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels Apr 9, 2021
@abikouo abikouo removed WIP Work in progress needs_info This issue requires further information. Please answer any outstanding questions labels Apr 14, 2021
@abikouo abikouo removed their assignment Apr 14, 2021
@abikouo
Copy link
Contributor

abikouo commented Apr 14, 2021

Hi @asifiqbal
Feature pull request has been merged.

@abikouo abikouo closed this as completed Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module module needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type)
Projects
None yet
Development

No branches or pull requests

5 participants