-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_snapshot_info add option for paginated requests #321
Conversation
…n_parameters.yaml to 321-ec2_snapshot_info-add_max_results_and_next_token_parameters.yaml
data_encryption_key_id: | ||
description: The data encryption key identifier for the snapshot. This value is a unique identifier that \ | ||
corresponds to the data encryption key that was used to encrypt the original volume or snapshot copy. | ||
snapshots: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For anyone else who sees this: this PR didn't change the results here, it's been this way since at least 2.9
Given support for 2.8 is about to be dropped I don't think it's worth adding a shim layer
Co-authored-by: Mark Chappell <[email protected]>
@@ -217,6 +217,61 @@ | |||
that: | |||
- info_result.snapshots| length == 3 | |||
|
|||
# check that snapshot_ids and max_results are mutually exclusive | |||
- name: Get info about all snapshots in paginated mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names of the new tasks should reflect what they are testing - in CI results we won't be able to see the code comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names of the new tasks should reflect what they are testing - in CI results we won't be able to see the code comments.
sure, I will update it
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to also require max_tokens to be set if next_token_id is set (so you can't set next_token_id if max_tokens isn't set)?
Co-authored-by: Mark Chappell <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
there are independent parameters. |
@jillr could you please review and merge this if ok ? (integration tests have been updated as requested) |
SUMMARY
add new options
max_results
andnext_token
to read snapshot in paginated mode#312
ISSUE TYPE
COMPONENT NAME
ec2_snapshot_info
ADDITIONAL INFORMATION
the following task will limit the number of snapshot returned in output