Improve unit test coverage of module_utils.policy #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
complexity/module_utils-policy
branch
from
2fa6797 to
c1b77b6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
…ble_policy slightly
tremble
force-pushed
the
complexity/module_utils-policy
branch
from
c1b77b6 to
af4171a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
goneri
reviewed
Oct 7, 2022
| if isinstance(tupleified, list): | ||
| tupleified = tuple(tupleified) | ||
| hashed_policy = _hashable_policy(each, []) | ||
| tupleified = _tuplify_list(hashed_policy) | ||
| policy_list.append(tupleified) | ||
| elif isinstance(policy, string_types) or isinstance(policy, binary_type): |
There was a problem hiding this comment.
You can write this like this: elif isinstance(policy, (binary_type, string_types)):
>>> a = True
>>> isinstance(a, (int, bool))
True
>>> a = 1
>>> isinstance(a, (int, bool))
True
>>> a = "a string"
>>> isinstance(a, (int, bool))
False
goneri
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
_hashable_policyto reduce complexity (and make testing easier)sort_json_policy_dict, it's very naive and was only used by ecs_ecrISSUE TYPE
COMPONENT NAME
plugins/module_utils/policy.py
ADDITIONAL INFORMATION